From 7084c7521db8508c09624345700f4c8a83a97c01 Mon Sep 17 00:00:00 2001 From: "rhyskidd@gmail.com" Date: Mon, 16 Jul 2012 15:54:06 +0000 Subject: =?UTF-8?q?PVS-Studio=20fix:=20V618=20It=E2=80=99s=20dangerous=20t?= =?UTF-8?q?o=20call=20the=20'sprintf=5Fs'=20function=20in=20such=20a=20man?= =?UTF-8?q?ner,=20as=20the=20line=20being=20passed=20could=20contain=20for?= =?UTF-8?q?mat=20specification.=20The=20example=20of=20the=20safe=20code:?= =?UTF-8?q?=20printf("%s",=20str);?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Stars45/MsnEditDlg.cpp | 2 +- Stars45/NavDlg.cpp | 2 +- Stars45/RadioTraffic.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'Stars45') diff --git a/Stars45/MsnEditDlg.cpp b/Stars45/MsnEditDlg.cpp index ed8f912..f26a52b 100644 --- a/Stars45/MsnEditDlg.cpp +++ b/Stars45/MsnEditDlg.cpp @@ -342,7 +342,7 @@ MsnEditDlg::DrawPackages() sprintf_s(txt, "%s %s", design->abrv, design->name); } else { - sprintf_s(txt, Game::GetText("MsnDlg.undefined").data()); + sprintf_s(txt, "%s", Game::GetText("MsnDlg.undefined").data()); } lst_elem->SetItemText(i, 3, txt); diff --git a/Stars45/NavDlg.cpp b/Stars45/NavDlg.cpp index 7ddd3cd..898636a 100644 --- a/Stars45/NavDlg.cpp +++ b/Stars45/NavDlg.cpp @@ -765,7 +765,7 @@ NavDlg::UpdateSelection() sprintf_s(shield, "%03d", sel_ship->ShieldStrength()); sprintf_s(hull, "%03d", sel_ship->HullStrength()); - sprintf_s(range, Game::GetText("NavDlg.not-avail").data()); + sprintf_s(range, "%s", Game::GetText("NavDlg.not-avail").data()); if (ship) { FormatNumberExp(range, Point(sel_ship->Location()-ship->Location()).length()/1000); diff --git a/Stars45/RadioTraffic.cpp b/Stars45/RadioTraffic.cpp index d87ed2f..ca5ab92 100644 --- a/Stars45/RadioTraffic.cpp +++ b/Stars45/RadioTraffic.cpp @@ -309,7 +309,7 @@ RadioTraffic::DisplayMessage(RadioMessage* msg) } else if (msg->Action() == RadioMessage::MOVE_PATROL) { - sprintf_s(msg_buf, TranslateVox("Move patrol.").data()); + sprintf_s(msg_buf, "%s.", TranslateVox("Move patrol.").data()); } else if (target && dst_ship && msg->Sender()) { -- cgit v1.1