From eaa453335563d670d856da44bf4ea1f332c618a7 Mon Sep 17 00:00:00 2001
From: rhyskidd <rhyskidd@076cb2c4-205e-83fd-5cf3-1be9aa105544>
Date: Wed, 30 May 2012 13:26:32 +0000
Subject: Ensure check for NULL pointer occurs prior to use, not after

---
 Stars45/MsnPkgDlg.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'Stars45/MsnPkgDlg.cpp')

diff --git a/Stars45/MsnPkgDlg.cpp b/Stars45/MsnPkgDlg.cpp
index 4d996bc..bfe8a6c 100644
--- a/Stars45/MsnPkgDlg.cpp
+++ b/Stars45/MsnPkgDlg.cpp
@@ -1,6 +1,6 @@
 /*  Project Starshatter 5.0
 	Destroyer Studios LLC
-	Copyright © 1997-2007. All Rights Reserved.
+	Copyright (C) 1997-2007. All Rights Reserved.
 
 	SUBSYSTEM:    Stars.exe
 	FILE:         MsnPkgDlg.cpp
@@ -205,13 +205,13 @@ MsnPkgDlg::DrawThreats()
 	if (!mission) return;
 
 	MissionElement* player = mission->GetPlayer();
+    
+    if (!player) return;
+    
 	Text            rgn0   = player->Region();
 	Text            rgn1;
 	int             iff    = player->GetIFF();
 
-	if (!player)
-	return;
-
 	ListIter<Instruction> nav = player->NavList();
 	while (++nav) {
 		if (rgn0 != nav->RegionName())
-- 
cgit v1.1